BIND 10 #256: bugs in base32.cc

[BIND 10 Development]

#256: bugs in base32.cc
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  stephen                    
          Type:  defect         |       Status:  reviewing                  
      Priority:  major          |    Milestone:  06. 4th Incremental Release
     Component:  DNSPacket API  |   Resolution:                             
      Keywords:                 |    Sensitive:  0                          
Estimatedhours:                 |        Hours:                             
      Billable:  1              |   Totalhours:                             
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => stephen


Comment:

 Replying to [comment:7 stephen]:

 > The "& ~7" still needs a brief comment (e.g. "the bitwise AND with ~7
 clears the lowest three bits, so has the effect of rounding the result
 down to the nearest multiple of 8").  I only mentioned this as it's non-
 obvious so it's something I think a reader would look at and puzzle over
 until they work it out. (Well, I did!)

 Hmm, maybe this is a typical example of the use of C as a bit more
 readable assembly, and explaining it may be either crucial or redundant
 depending on where the reader lives in the programming language
 hierarchy:-)

 Anyway, I admit this may look tricky, so added some comments (mostly
 adopting your example).  r2546.

 > > '''src/lib/dns/util/README'''
 > > :
 > > Good point, I tried to clarify it in a revised README (r2539).
 Actually, I'm not 100% sure
 > > this is an agreed development policy. Maybe we should discuss it in
 the weekly call.
 >
 > I think that would be a useful discussion.
 >
 My understanding is it will go to a separate ticket.  For the moment I
 think we can move forward with the current README.

 Is there any outstanding issue, or can I now merge it to trunk?

-- 
Ticket URL: <http://bind10.isc.org/ticket/256#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development