BIND 10 #176: python logging framework
BIND 10 Development
do-not-reply at isc.org
Tue Jun 1 13:34:17 UTC 2010
#176: python logging framework
---------------------+------------------------------------------------------
Reporter: jreed | Owner: zzchen_pku
Type: task | Status: reviewing
Priority: major | Milestone: 04. 2nd Incremental Release: Early Adopters
Component: logging | Resolution:
Keywords: | Sensitive: 0
---------------------+------------------------------------------------------
Comment(by zhanglikun):
Sorry, continue my comment:
change
{{{
'''
How are you
I am fine
'''
}}}
to
{{{
'''How are you
I am fine'''
}}}
3. You'd better give a better name to class SLHandler? Since I thought
it's about SSL.
4. If the function or variable in class won't be called directly by
others, add undercore '_' to function or variable name.
5. test case 'test_log_message' in log_test.py should be redesigned
properly.
Anyway, I suggest to delay merging code to trunk before fixing these
problems.
--
Ticket URL: <https://bind10.isc.org/ticket/176#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list