BIND 10 #219: (review) bindctl rejects IPv6 addresses

[BIND 10 Development]

#219: (review) bindctl rejects IPv6 addresses
----------------------+-----------------------------------------------------
 Reporter:  jinmei    |       Owner:                                             
     Type:  defect    |      Status:  new                                        
 Priority:  critical  |   Milestone:  04. 2nd Incremental Release: Early Adopters
Component:  bind-ctl  |    Keywords:                                             
Sensitive:  0         |  
----------------------+-----------------------------------------------------
 When I tried to trigger xfr using IPv6 via bindctl, I saw:
 {{{
 > Xfrin retransfer master = 2001:4f8:3:36::162 zone_name = jinmei.org
 Error!  Parameter format error, it should like 'key = value'
 }}}

 This is because IPv6 addresses are not recognized as a "parameter value".
 The attached simple patch fixes this.  Please reivew.  I hope this will be
 included in the next release.

 Aside from the immediate problem, I have some additional comments on the
 current behavior:

  - I don't think it makes sense to expect a specific format as acceptable
 "parameter values" as it's very likely that we add more variations of
 parameters.  I believe the command parser should only do minimal check
 like "parameter value is a sequecne of non space characters", "quoted
 string" is an string surrounded by quotation marks (such marks themselves
 can be part of the string in an escaped form).
  - I susepct "quota_str" and "QUOTA_PATTERN" are typo, and should be
 "quoted"/"QUOATED"
  - the error message is unfirendly.  it should at least identify which
 part of the input causes the error.

-- 
Ticket URL: <https://bind10.isc.org/ticket/219>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development