BIND 10 #151: XfroutClient socket location and removal

BIND 10 Development do-not-reply at isc.org
Mon Jun 7 11:15:08 UTC 2010


#151: XfroutClient socket location and removal
--------------------+-------------------------------------------------------
 Reporter:  jreed   |        Owner:  jreed                      
     Type:  defect  |       Status:  assigned                   
 Priority:  major   |    Milestone:  05. 3rd Incremental Release
Component:  xfrout  |   Resolution:                             
 Keywords:          |    Sensitive:  0                          
--------------------+-------------------------------------------------------

Comment(by shane):

 Replying to [comment:17 zhanglikun]:
 > Hi Jeremy, Could have a review of the patch I just created again, I just
 worry about whether the os.unlink(sock_file) will throw an exception
 caused by some privilege problem. that means if unlink the file failed,
 the xfrout process still need exit.
 >
 > if err.errno == errno.ECONNREFUSED:
 >     os.unlink(sock_file)

 Hm... good point. Actually this should probably be removed from the
 `_sock_file_in_use()` function. It is an unexpected side-effect, based on
 the name of the function.

 If the `unlink()` is moved out of the checking function, the original
 `unlink()` can be left in the `__init__()` function.

-- 
Ticket URL: <https://bind10.isc.org/ticket/151#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list