BIND 10 #220: suggestions to bindctl

BIND 10 Development do-not-reply at isc.org
Fri Jun 11 14:20:13 UTC 2010


#220: suggestions to bindctl
-------------------------+--------------------------------------------------
 Reporter:  jinmei       |        Owner:  jreed                                         
     Type:  enhancement  |       Status:  reviewing                                     
 Priority:  minor        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  bind-ctl     |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------

Comment(by jreed):

 I can't remember my related change to check. But I do have some comments
 for r2108:

 - what if HOME isn't defined?

 - FAIL_TO_CONNEC_WITH_CMDCTL has typo (CONNECT end with "T")

 - error message is not accurate "Cannot determine location of $HOME. Not
 storing default user" since there it is not checking for HOME. Maybe the
 check earlier for $HOME should also first try getpwnam (to get pw_dir) --
 nevertheless I don't know python nor portable way to do that, but is more
 accurate than just relying on environment variable which may not be set by
 some automated tasks (non-login) for example.

 - also error "Cannot write ~/.bind10/default_user.csv; default user is not
 stored" -- may be more accurate if it printed the dir + file_name instead
 of hardcoded value

 (I didn't run code yet.)

-- 
Ticket URL: <https://bind10.isc.org/ticket/220#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list