BIND 10 #238: tests for src/bin/cfgmgr/b10-cfgmgr.py

[BIND 10 Development]

#238: tests for src/bin/cfgmgr/b10-cfgmgr.py
---------------------------+------------------------------------------------
 Reporter:  jreed          |        Owner:  UnAssigned                                    
     Type:  task           |       Status:  reviewing                                     
 Priority:  minor          |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  configuration  |   Resolution:                                                
 Keywords:                 |    Sensitive:  0                                             
---------------------------+------------------------------------------------

Comment(by jinmei):

 Replying to [comment:1 jelte]:
 > Changes in branches/238
 >
 > Had to do a bit of module import magic to get the code to run, and all
 the tests really do is check if the global variables are as expected and
 the needed functions are called (which is, coincidentally, also everything
 the script does :) )

 I basically have no objection to the patch.

 Two minor nits:
  - typo: s/moculde/module/ (?)
 {{{
 +        # moculde ConfigManager in it.
 }}}

  - what's "aay"?
 {{{
 +        # (and rename the .in aay from this file again)
 }}}

 And, not actually for the tests, but I wonder:
  - what if write_config() fails?  (or can we assume it doesn't raise an
 exception?)
  - is it okay to do write_config() evn if the try block fails due to some
 unexpected exception?  For example, isn't it possible it has incomplete
 data if read_conifg() fails?

 I don't know if these are real issues, and even if so, they can (and
 probably should) go to a different ticket.

-- 
Ticket URL: <https://bind10.isc.org/ticket/238#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development