BIND 10 #225: b10-auth fails if ran from source tree

[BIND 10 Development]

#225: b10-auth fails if ran from source tree
----------------------+-----------------------------------------------------
 Reporter:  jreed     |        Owner:  jelte                                         
     Type:  defect    |       Status:  reviewing                                     
 Priority:  major     |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  b10-auth  |   Resolution:                                                
 Keywords:            |    Sensitive:  0                                             
----------------------+-----------------------------------------------------

Comment(by jelte):

 Replying to [comment:6 jinmei]:
 >  - I don't like to see hardcoded magic values such as "src/bin/auth".
 understanding this is probably a short-to-middle term hack, I can live
 with that, but if possible please consider centralizing the definition of
 these things

 Yes, let's make a separate ticket for that, I have some (incomplete) ideas
 on how to do this better, partly related to having access to configuration
 of non-running modules

 >  - Please add tests for xfrin

 Any idea on how? The tests use a test-specific database file, so I think
 this is more integration-testing than unit testing. Something with
 cucumber perhaps?

 >  - xfrout: shouldn't we perform remove_remote_config() somewhere?

 In principle it shouldn't be necessary, it should be handled by the
 cleanup routines of ccsession if not called manually. Though I now see
 what needs to be done is missing there (a call to group_unsubscribe),
 which is only partly related to this ticket, creating a new ticket for
 that too.

 >  - !UnixSockServer.get_db_file() do we really need to acquire a lock
 here?  with your change it seems to eliminate the possibility of race.
 besides, since get_remote_config_value() can be time consuming (right?),
 this can be a giant lock.

 Actually it doesn't take much time, 'remote config' follows a push-
 mechanism, so the pain is there on config changes, not on config access,
 and this is simply a dict lookup. You're right right about not needing a
 lock here, but now that you mention it, we might need them in ccsession
 itself...

 >  - changelog: s/feature/func/ (unless you tried to rename func to
 feature, but that should go to a different ticket anyway)

 ack.

-- 
Ticket URL: <http://bind10.isc.org/ticket/225#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development