BIND 10 #200: use new Name::split() in data source
BIND 10 Development
do-not-reply at isc.org
Thu Jun 17 16:08:12 UTC 2010
#200: use new Name::split() in data source
-------------------------+--------------------------------------------------
Reporter: jinmei | Owner: jinmei
Type: enhancement | Status: reviewing
Priority: minor | Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: data source | Resolution:
Keywords: | Sensitive: 0
-------------------------+--------------------------------------------------
Changes (by each):
* owner: each => jinmei
Comment:
for (int i = diff - 1; i >= 0; --i) {
const Name sub(task->qname.split(i));
I'm not sure, but I think maybe the ">= 0" should be "> 0". As written, I
think this would cause it to match down all the way to the qname itself,
whereas we actually want it to stop matching at the parent.
Also, I think you can eliminate the "nlen" variable now.
Otherwise the patch looks fine.
--
Ticket URL: <http://bind10.isc.org/ticket/200#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list