BIND 10 #221: Refactoring auth server and merge the axfr and notify logic into it
BIND 10 Development
do-not-reply at isc.org
Fri Jun 18 03:12:52 UTC 2010
#221: Refactoring auth server and merge the axfr and notify logic into it
-------------------------+--------------------------------------------------
Reporter: hanfeng | Owner: hanfeng
Type: enhancement | Status: reviewing
Priority: major | Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: b10-auth | Resolution:
Keywords: | Sensitive: 0
-------------------------+--------------------------------------------------
Changes (by jinmei):
* owner: jinmei => hanfeng
Comment:
First off, could you rebase this branch so that it will use non boost
ASIO?
Right now it seems to partially merge recent changes of trunk:
- it has new asio_link.{h,cc}
- but it doesn't have ext/asio
Since this part of change in trunk affects this patch substantially, it
doesn't make sense to base it with an older version of trunk (and partial
incorporation cannot be an option, of course).
On top of that, please:
- don't include asio.hpp from asio_link.h. It breaks build, and that's
exactly the reason why we introduced asio_link.
- don't use "using namespace asio::ip" in a header file. this is
generally a bad practice.
I'm now giving the ticket back to hanfeng.
Oh, and when you rebase it, I suggest you change the branch name using our
common convention: trac### (in this case trac221).
--
Ticket URL: <https://bind10.isc.org/ticket/221#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list