BIND 10 #249: review: auth server can return SERVFAIL with an answer

[BIND 10 Development]

#249: review: auth server can return SERVFAIL with an answer
-------------------------+--------------------------------------------------
 Reporter:  jinmei       |        Owner:  jinmei                                        
     Type:  defect       |       Status:  reviewing                                     
 Priority:  major        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  data source  |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------

Comment(by each):

 Suggestion for a way to combine both sorts of servfail handling:

 {{{
     try {
         Query query(message, dnssec_ok);
         impl_->data_sources_.doQuery(query);
     } catch (const Exception& ex) {
         message.setRcode(Rcode::SERVFAIL());
     }

     if (message.getRcode() == Rcode::SERVFAIL()) {
         if (impl_->verbose_mode_) {
             cerr << "[b10-auth] Internal error, returning SERVFAIL: " <<
                 ex.what() << endl;
         }

         makeErrorMessage(message, response_renderer, Rcode::SERVFAIL(),
                          impl_->verbose_mode_);
         return (true);
     }
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/249#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development