BIND 10 #175: Loadzone: Add verbose options to exactly what is happening with loadzone

BIND 10 Development do-not-reply at isc.org
Tue Jun 29 13:17:18 UTC 2010


#175: Loadzone: Add verbose options to exactly what is happening with loadzone
------------------------+---------------------------------------------------
 Reporter:  zhanglikun  |        Owner:  shentingting                                  
     Type:  task        |       Status:  reviewing                                     
 Priority:  major       |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  loadzone    |   Resolution:                                                
 Keywords:              |    Sensitive:  0                                             
------------------------+---------------------------------------------------
Changes (by shane):

  * owner:  shane => shentingting


Comment:

 Okay, there are a few minor points, but I think it is basically ready:

   * The `TODO` file still seems to list things that are fixed with this
 branch. I am not sure, though!
   * The `error_test.sh` script needs to add `"-d zone.sqlite3"` like the
 correct_test.sh script has.
   * In `parse_ttl()`, it is probably easier to use `ttl_expr.isdigit()`
 rather than `re.match('\d+$', ttl_expr).
   * In `parse_ttl()` I think there is an unnecessary copy:
 {{{
     ttl = int(ttl_expr[:])   # this converts a copy of the ttl_expr string
 to an int
     ttl = int(ttl_expr)      # this does the exact same thing without the
 copy
 }}}
   * Since this no longer uses threading, the `"import threading"` can be
 removed from the top of `master.py`

 If you make these changes, I think it should be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/175#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list