BIND 10 #167: review: configure addresses and ports to listen on for DNS servers

[BIND 10 Development]

#167: review: configure addresses and ports to listen on for DNS servers
----------------------+-----------------------------------------------------
 Reporter:  larissas  |        Owner:  each                                          
     Type:  task      |       Status:  reviewing                                     
 Priority:  major     |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  b10-auth  |   Resolution:                                                
 Keywords:            |    Sensitive:  0                                             
----------------------+-----------------------------------------------------

Comment(by each):

 Thank you for the review.  As some of the comments were unrelated to the
 specifics of this ticket I have created a new cleanup ticket, #259, and
 moved the comments there.  The items remaining that appear to me to be
 related to this specific change are these:

 Replying to [comment:18 stephen]:
 > ''run_server()''
 > There is no check that the "port" argument is valid.  This function
 converts the passed string to "short" via a call to "atoi()", but atoi()
 makes no check as to the validity of the argument.  Suggest that this
 could be checked via a call to boost::lexical_cast.
 >
 > Remark: If the address argument does not match the flag -4/-6, an error
 message is output and the program terminated via a call to exit().
 However, main() explicitly deletes the auth_server object before
 terminating.  If this latter behaviour is desired in all cases, run_server
 should return on error instead of exiting.
 >
 > Slight inconsistency: the first "if" checks "if (address != NULL)", the
 second "if" checks "if (address)".  (In fact, the first clause of the
 second "if" could be combined into the first "if" construct.)
 >
 > It appears that if "address" is given, the servers.xxx4_server variables
 are set regardless of whether the address is an IPV4 or IPV6 address.
 >
 > ''main()''
 > The "case" branch parsing of "-6" results includes what looks like
 temporary code 'cout << "here" << endl'.

 If I left out anything that you would like to see addressed in this
 ticket, let me know.  Otherwise, I'll take care of these this afternoon.

-- 
Ticket URL: <http://bind10.isc.org/ticket/167#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development