BIND 10 #181: python wrappers to support xfr
BIND 10 Development
do-not-reply at isc.org
Wed Jun 30 08:08:41 UTC 2010
#181: python wrappers to support xfr
----------------------+-----------------------------------------------------
Reporter: larissas | Owner: jelte
Type: task | Status: reviewing
Priority: major | Milestone: 05. 3rd Incremental Release: Serious Secondary
Component: xfrin | Resolution:
Keywords: | Sensitive: 0
----------------------+-----------------------------------------------------
Changes (by stephen):
* owner: stephen => jelte
Comment:
I've checked the changes (in revision 2340). All are OK, but I have one
last question: in name_python.cc (line 647)
{{{root_name->name = new Name(".")}}}
was replaced with
{{{root_name->name = const_cast<Name*>(&Name::ROOT_NAME())}}}
In the original assignment, the "Name" object was allocated on the heap.
In the replacement, the "Name" object returned by Name::ROOT_NAME() is a
statically-declared singleton. If root_name is ever destroyed, the
destructor will not be able to deleted the pointed-to Name object.
--
Ticket URL: <http://bind10.isc.org/ticket/181#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list