BIND 10 #167: review: configure addresses and ports to listen on for DNS servers

[BIND 10 Development]

#167: review: configure addresses and ports to listen on for DNS servers
----------------------+-----------------------------------------------------
 Reporter:  larissas  |        Owner:  each                                          
     Type:  task      |       Status:  reviewing                                     
 Priority:  major     |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  b10-auth  |   Resolution:                                                
 Keywords:            |    Sensitive:  0                                             
----------------------+-----------------------------------------------------
Changes (by stephen):

  * owner:  stephen => each


Comment:

 Checked revision 2341:

 1) Although the "if" blocks have been combined (in run_server), should an
 address is given the code will still set the servers.xxx4_server variables
 even if the address is an IPV6 address.

 2) Entering an invalid port on the command line will result in the output
 of the somewhat cryptic message "bad lexical cast: source type value could
 not be interpreted as target". I would suggest that that exception is
 caught and re-thrown with a more user-friendly message.

 3) Something I missed in the original review is that the numeric port
 number should be "unsigned short" all the way through the code (it is
 currently declared as "short").

-- 
Ticket URL: <http://bind10.isc.org/ticket/167#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development