BIND 10 #69: review: data source hangs with CNAME loops

[BIND 10 Development]

#69: review: data source hangs with CNAME loops
-------------------------+--------------------------------------------------
 Reporter:  jinmei       |        Owner:  each                                          
     Type:  defect       |       Status:  reviewing                                     
 Priority:  minor        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  data source  |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------
Changes (by stephen):

  * owner:  stephen => each


Comment:

 Reviewing revision 2325. Files modified/added since the branch was created
 at revision 2269:

 M       src/lib/datasrc/tests/datasrc_unittest.cc
 M       src/lib/datasrc/data_source.cc
 M       src/lib/dns/message.h
 M       src/lib/dns/message.cc

 Review of the changes made between 2269 and 2535

 '''src/lib/datasrc/tests/datasrc_unittest.cc'''
 OK

 Note: One test is disabled (synthesisedCnameTooLong).  When re-enabled,
 the test fails because the exception !TooLongName is thrown.  Isn't this
 expected?

 '''src/lib/datasrc/data_source.cc'''
 OK

 Remark: addToMessage() returns no indication is returned as to whether the
 addition of the RRset to the message succeeded or failed because of an
 already-existing one.  Is there an advantage to returning a bool and
 having callers test the return value as an internal consistency check?

 '''src/lib/dns/message.h'''
 OK

 '''src/lib/dns/message.cc'''
 OK

 Remark: The method addRRset() has a comment "Note: should check duplicate
 (TBD)".  Should the check be done here or (as it now is) in
 addToMessage()?

-- 
Ticket URL: <http://bind10.isc.org/ticket/69#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development