BIND 10 #192: Data source hotspot cache

[BIND 10 Development]

#192: Data source hotspot cache
-------------------------+--------------------------------------------------
 Reporter:  each         |        Owner:  jinmei                                        
     Type:  enhancement  |       Status:  reviewing                                     
 Priority:  major        |    Milestone:  05. 3rd Incremental Release: Serious Secondary
Component:  b10-auth     |   Resolution:                                                
 Keywords:               |    Sensitive:  0                                             
-------------------------+--------------------------------------------------

Comment(by jinmei):

 quick review comments on r2363 as requested:
  - I have some proposed style fixes.  directly committed to branch. r2368.
 not using default parameter may be a matter of style preference, but IMO
 it can easily cause surpring bugs we should avoid using it unless we use
 the default parameter in so many cases (which is not the case here).
  - in data_source.cc
 {{{
 +        flags = count = 0;
 }}}
   I don't see why we need to reset count here. (actually the same for
 flags).  as I noted before, the long and complecated code logic tends to
 make us confused and introduce unnecessary or buggy operations.  this
 seems to be another indication of the need for refactor, but for now I
 don't require that.  Either just remove it, or according to BIND 9's
 coding guideline use separate lines for the two assignments.
  - DuplicateQuery looks okay, although I want to have more comprehensive
 tests in this sense.

 not a direct comment on the patch:

 {{{
 -            return (DataSrc::SUCCESS);
 +            return (true);
 }}}

 this type of error is one major reason why I generally prefer types
 instead of numerics.  In this specific case I may choose enum, though.

-- 
Ticket URL: <http://bind10.isc.org/ticket/192#comment:43>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development