BIND 10 #184: cfgmgr test coverage

[BIND 10 Development]

#184: cfgmgr test coverage
--------------------------+-------------------------------------------------
 Reporter:  jinmei        |        Owner:  jelte                      
     Type:  task          |       Status:  assigned                   
 Priority:  major         |    Milestone:  04. 2nd Incremental Release
Component:  Unclassified  |   Resolution:                             
 Keywords:                |    Sensitive:  0                          
--------------------------+-------------------------------------------------
Changes (by jinmei):

  * owner:  => jelte
  * status:  new => assigned


Comment:

 Frankly, I'm not sure what we should do for this backlog.

 At least line-based coverage wise it's already quite complete:
 http://bind10.isc.org/~tester/LATEST_PYTHON_UNITTEST_COVERAGE/src_lib_python_isc_config_cfgmgr.html

 Nevertheless, I've added a couple of tests for minor corner cases to make
 it even more complete.  The new tests are available in branches/184, which
 are ready for review.

 While writing this tests I've noticed some possible issues of the code:
  - when !ConfigManagerData.write_to_file() fails after creating a
 temporary file, it won't clean up the tmp file.  It probably should do so.
  - on a related note, we should probably use Python's tmpfile module so
 that the temporary file will have a unique file name and will be cleaned
 up automatically.
  - as commented in the test case, however, if we do this the newly added
 test won't work as expected because it assumes a fixed name temporary
 file.  but it's probably okay; hard-coding such an assumption in test code
 is probably not a good practice anyway.

 I'm going to give this small ticket to Jelte, because he should be most
 familiar with the code, and this ticket contains some comments on the
 implementation (i.e. tested code) itself.

-- 
Ticket URL: <http://bind10.isc.org/ticket/184#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development