BIND 10 #49: different signature for Name::split()

[BIND 10 Development]

#49: different signature for Name::split()
---------------------------+------------------------------------------------
 Reporter:  jinmei         |        Owner:  jinmei                     
     Type:  enhancement    |       Status:  reviewing                  
 Priority:  major          |    Milestone:  04. 2nd Incremental Release
Component:  DNSPacket API  |   Resolution:                             
 Keywords:                 |    Sensitive:  0                          
---------------------------+------------------------------------------------
Changes (by jelte):

  * owner:  jelte => jinmei


Comment:

 I'm not entirely sure how useful createSuffixNameOf() is; i'd just as
 easily write

 {{{
 for(i = label.getLabelCount(); i>0; --i) {
         Name n(createAncestorOf(label));
         <etc>
 }
 }}}

 and we'd have to look up which one did what every time we used it (since
 the names don't really make that clear to me)...

 (to be completely honest, i wouldn't even mind adding a second
 name::split(int) for this, but have no objections to the current
 approach).

 Apart from that, code looks good.

 Does data really become a link in doxygen comments?

-- 
Ticket URL: <https://bind10.isc.org/ticket/49#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development