BIND 10 #184: cfgmgr test coverage

BIND 10 Development do-not-reply at isc.org
Tue May 18 17:03:47 UTC 2010


#184: cfgmgr test coverage
--------------------------+-------------------------------------------------
 Reporter:  jinmei        |        Owner:  jelte                      
     Type:  task          |       Status:  reviewing                  
 Priority:  major         |    Milestone:  04. 2nd Incremental Release
Component:  Unclassified  |   Resolution:                             
 Keywords:                |    Sensitive:  0                          
--------------------------+-------------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => jelte


Comment:

 Replying to [comment:3 jelte]:

 > Please review attached patch too :)

 This one looks okay (but see below).

 > I'm not sure we still need the second of these new tests if we use this
 patch (kind of what you said already). Having the first seems ok.

 maybe we can temporarily tweak self.config_manager_data.data_path before
 doing write_to_file() so that !NamedTemporaryFile() will fail.

 Whether or not we do this test, note that if !NamedTemporaryFile() fails
 it will raise an an OSError, not an IOError.  So we should probably remove
 the except block for IOError (as it would not actually be "expected" in
 this case and should be handled at a higher level if it ever happens).

-- 
Ticket URL: <http://bind10.isc.org/ticket/184#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list