BIND 10 #168: separate ASIO from Boost and remove custom code

[BIND 10 Development]

#168: separate ASIO from Boost and remove custom code
--------------------------+-------------------------------------------------
 Reporter:  larissas      |        Owner:  each                                       
     Type:  task          |       Status:  reviewing                                  
 Priority:  major         |    Milestone:  04. 2nd Incremental Release: Early Adopters
Component:  Unclassified  |   Resolution:                                             
 Keywords:                |    Sensitive:  0                                          
--------------------------+-------------------------------------------------

Comment(by each):

 > Okay, I figured it out.  That's because there are some functions that
 hit the "unused-parameter" warning in header files of the non boost
 version of ASIO.  I suspect we were free from this in the boost version
 because we used a separate object library where the source code that would
 hit the warning is hidden.

 Odd... it compiles fine for me, with the code in the branch.  I guess it's
 because there are boost headers in /usr/include that avoid the unused
 parameter warning somehow?

 > that is, {{{UNUSED_PARAM}}} is specified.  I guess Evan explicitly added
 this to the original source code.

 Ah, yes I had.  It was intended as a temporary hack, which I would go back
 and resolve in some other way after I had the rest of the code working,
 and then I promptly forgot about it. :)

 > I've not come up with a satisfactory solution, but I'm attaching a patch
 that I think is least evil: it introduces a small wrapper module
 (asio_link) as a separate internal "library" (only used for b10-auth), and
 exclude unused-parameter from the erroneous warnings only for that
 library.

 This seems reasonable.  I don't see your new asio_link.{cc,h} files in the
 diff you attached (I guess you did an "svn diff" but forgot the "svn
 add"), but please go ahead and commit the changes to the trac168 branch.
 I'll revert the configure.ac changes, rearrange the "ext" directory, and
 ensure that the local copy of the asio headers are included regardless of
 --with-boost-include.  Thank you for your help on this.

-- 
Ticket URL: <https://bind10.isc.org/ticket/168#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development