BIND 10 #358: more cleanup for the message class

BIND 10 Development do-not-reply at isc.org
Tue Nov 2 14:41:26 UTC 2010


#358: more cleanup for the message class
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  jinmei               
          Type:  task           |       Status:  reviewing            
      Priority:  major          |    Milestone:  y2 12 month milestone
     Component:  DNSPacket API  |   Resolution:                       
      Keywords:                 |    Sensitive:  0                    
Estimatedhours:  0.0            |        Hours:  0                    
      Billable:  1              |   Totalhours:  0                    
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by vorner):

  * owner:  vorner => jinmei


Comment:

 The code seems ok and IMO can be merged.

 There's just one think I'd like to propose. The enums, if numbers are not
 assigned explicitly, start at 0 and increase by 1 for each following
 value. I saw having a MAX_<whatever> value as the last one and used the
 way you use NUM_SECTIONS. It has the nice property of updating the count
 automatically when new value is added (it is really not probable that the
 number of sections would change, thought). You can implement it if you
 like it or keep it as it is.

-- 
Ticket URL: <http://bind10.isc.org/ticket/358#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list