BIND 10 #397: Port generic red-black tree (RBT) data structure from BIND-9
BIND 10 Development
do-not-reply at isc.org
Thu Nov 4 05:49:22 UTC 2010
#397: Port generic red-black tree (RBT) data structure from BIND-9
------------------------------+---------------------------------------------
Reporter: zzchen_pku | Owner: zzchen_pku
Type: enhancement | Status: reviewing
Priority: major | Milestone:
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Changes (by jinmei):
* owner: UnAssigned => zzchen_pku
Comment:
Replying to [comment:3 zzchen_pku]:
> branches/trac397 is ready for review now.
> The initial version will onpy provide basic interfaces:
add/remove/search.
Some prilimiray feedback:
- I've noticed there are trivial violations of coding style guidelines.
could you first fix trivial issues so that we can focus on the code logic
later?
- brace position
- missing '()' after retrun
- missing braces
- the code generally seems to be undocumented. in particular,
rbt_datasrc.h doen't have any class/member documentation. please add
them.
- some major part of the code aren't tested according to lcov. e.g.
about a half of RBNode::successor() isn't tested. please run lcov and
make sure most major part of the code are covered.
--
Ticket URL: <http://bind10.isc.org/ticket/397#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list