BIND 10 #394: memory leaks in branches/trac327 (after io_service refactors)

[BIND 10 Development]

#394: memory leaks in branches/trac327 (after io_service refactors)
-------------------------------+--------------------------------------------
      Reporter:  jelte         |        Owner:  jelte    
          Type:  defect        |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0        
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by vorner):

  * owner:  vorner => jelte


Comment:

 The changes look ok and can be merged. There's just one small thing I
 noticed, but it does not seem really important: In tcpdns.cc, there's the
 lenbuf, which is created each time the coroutine is entered/reentered. It
 is small, but it could be moved into a block at the place where it is
 needed (most instances will be unused). I'll leave it up to you to decide
 if you want to do it or leave it as it is.

 Valgrind still finds something it calls „possibly lost“ (which usually
 means probably not lost). I'd like to have a look at them at some point,
 but I think it is better to merge and close this now than keeping the
 branch old, as the possible leaks look like not related to -recurse or
 coroutines at all.

-- 
Ticket URL: <http://bind10.isc.org/ticket/394#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development