BIND 10 #402: Refactoring authoritative and recursive tests

[BIND 10 Development]

#402: Refactoring authoritative and recursive tests
-----------------------------+----------------------------------------------
      Reporter:  zhanglikun  |        Owner:  zhanglikun
          Type:  task        |       Status:  reviewing 
      Priority:  major       |    Milestone:            
     Component:  recurser    |   Resolution:            
      Keywords:              |    Sensitive:  0         
Estimatedhours:  0.0         |        Hours:  0         
      Billable:  1           |   Totalhours:  0         
      Internal:  0           |  
-----------------------------+----------------------------------------------
Changes (by vorner):

  * owner:  vorner => zhanglikun


Comment:

 I see two minor problems, most from the style point of view:
 • I do not think it makes sense to have the common tests under one chosen
 server (auth in this case) and make it somehow privileged, or how to say
 it. They are on the same level. I think this should be moved to
 src/lib/srvtest or something like that (the lib wouldn't install, it would
 be used just by the tests).
 • Shouldn't srv_unittest.h include srv_test.h? It is useless without it
 (it wouldn't work to include just the srv_unittest.h, it needs srv_test.h
 to be already included).

 I hope this is kind of internal change that will not need a changelog. Do
 you agree?

 Because I did the sync of #327 with trunk, merging this one will introduce
 few collisions. For example, I moved all occurrences of DummySocket under
 libasiolink (there was need for one more use, having something like 4
 copies looked too much).

 Do you mind if I take care of the two things I mentioned above, sync this
 branch with #327 and pass the review to someone else after that and merge,
 when you are going on vacation?

-- 
Ticket URL: <https://bind10.isc.org/ticket/402#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development