BIND 10 #356: Resolver address database

[BIND 10 Development]

#356: Resolver address database
-------------------------------+--------------------------------------------
      Reporter:  stephen       |        Owner:  ocean    
          Type:  enhancement   |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0        
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by stephen):

  * owner:  stephen => ocean


Comment:

 '''nameserver_address.h'''[[BR]]
 Rather than check that the ns_ shared_ptr is non-NULL in both updateRTT()
 and getAddress(), it might be better to check that it is non-NULL when the
 object is constructed and to throw an exception if it is. (There should be
 no case when a !NameserverAddress object is constructed with a null
 !NameserverEntry pointer.)

 '''nameserver_entry.cc'''[[BR]]
 Comment: Since NameserverEntry::getAddressAtIndex() should only be called
 from NameserverAddress::getAddress() - where the index is presumed to be
 valid - using "assert" instead of throing an exception is OK. (No change
 is needed.)

 '''nameserver_address_unittest.cc'''
 The RTT update test only tests that the RTT of the address at the
 specified index is updated.  It does not test that the RTT of other
 addresses associated with the nameserver are not changed.

 The tests should also test what happens if the index is out of range.

-- 
Ticket URL: <https://bind10.isc.org/ticket/356#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development