BIND 10 #401: Timouts in the recursor

[BIND 10 Development]

#401: Timouts in the recursor
------------------------------+---------------------------------------------
      Reporter:  vorner       |        Owner:  vorner   
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  recurser     |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by stephen):

  * owner:  stephen => vorner


Comment:

 '''src/lib/asiolink/udpdns.cc'''[[BR]]
 There are no comments describing "Priv" nor any of its attributes. (See
 below for a comment about the name of the structure.)


 '''src/lib/asiolink/tests/udpdns_unittest.cc'''[[BR]]
 Please check with Shane about the modification to the standard copyright
 notice (i.e. the change to copyright CZ.nic).  I'm not certain what the
 arrangement was concerning copyright.

 Perhaps change the name of the test class from UDPQuery?  Although it is
 in a different namespace, there is a risk of confusion with the
 asiolink::UDPQuery class.

 The standard seems to be to append an underscore to class member
 variables; this should be considered here.

 Test classes and methods should be documented to the same standards as the
 code being tested (so method and class headers should be added).

 In TEST_F(UDPQuery, stop), it is not clear why two calls to service.post()
 are being made.  The check only tests that the callback function is
 called, and does not seem to distinguish the effects of the two calls.

 '''src/lib/asiolink/internal/udpdns.h'''[[BR]]
 Using a shared_ptr is a good idea to minimise the overhead of copying.
 However, "Priv" is not a very descriptive name for the structure (I
 thought it was short for "privilege").  I would suggest something like
 "!UdpQueryData".

 The comment describing the private data mentions that the object is copied
 often.  I suggest that the reason it is copied often (i.e. that it is used
 as the callback object in the asynch_*() functions) be noted.

 '''src/lib/asiolink/asiolink.cc'''[[BR]]
 Class !RunningQuery should have some header documentation about its
 purpose.

-- 
Ticket URL: <http://bind10.isc.org/ticket/401#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development