BIND 10 #411: isc.datasrc.master's isttl() regex is broken
BIND 10 Development
do-not-reply at isc.org
Tue Nov 16 16:24:51 UTC 2010
#411: isc.datasrc.master's isttl() regex is broken
------------------------------+---------------------------------------------
Reporter: jreed | Owner: UnAssigned
Type: defect | Status: reviewing
Priority: major | Milestone: y2 12 month milestone
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Changes (by jinmei):
* owner: => UnAssigned
* status: new => reviewing
* milestone: => y2 12 month milestone
Comment:
Replying to [ticket:411 jreed]:
> (Problem reported on bind10-dev.)
>
> isttl in isc.datasrc.master matches 4ever.de label as a TTL.
>
I believe I've fixed it in branches/trac411. It's ready for review.
I also noticed b10-loadzone and the python datasrc module don't have
python unit tests (loadzone has some manual test data, but relying on such
things is a bad practice). This is BAD.
As an initial step toward the right direction, I've created a tests
directory and added some simple tests for this particular problem.
The proposed changelog entry is as follows:
{{{
117. [bug] jinmei
The master file parser of the python datasrc module incorrectly
regarded a domain name beginning with a decimal number as a TTL
specification. This confused b10-loadzone and had it reject to
load a zone file that contains such a name. (Trac #410, svn rTBD)
}}}
> The parsing should use the new python wrapper around the dns library.
Yes, but libdns++ doesn't yet support fancy TTL spec such as "1D".
--
Ticket URL: <http://bind10.isc.org/ticket/411#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list