BIND 10 #399: zone table class for in memory data source
BIND 10 Development
do-not-reply at isc.org
Mon Nov 22 10:08:55 UTC 2010
#399: zone table class for in memory data source
------------------------------+---------------------------------------------
Reporter: jinmei | Owner: zzchen_pku
Type: task | Status: reviewing
Priority: major | Milestone: y2 12 month milestone
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Changes (by jinmei):
* owner: jinmei => zzchen_pku
Comment:
Replying to [comment:3 zzchen_pku]:
> Looks okay, only two minor questions:
>
> '''src/lib/datasrc/zonetable.cc'''[[BR]]
> It seems variable "qname" in find() has never been used.
>
Good catch, fixed in r3585.
> '''src/lib/datasrc/tests/zonetable_unittest.cc'''[[BR]]
> Maybe we can add more zones whose origins are super domains of the given
name for validating longest match(For example, add "com" and
"example.com", then query "www.example.com").
>
Added it: r3586.
I've also noticed minor errors in doxygen comments, and fixed them in
r3587.
Finally, I realized I didn't propose a changelog entry for this ticket.
I'm not sure if we need one for this type of intermediate change, but I'm
going to propose it anyway (maybe we should discuss it in the bi-weekly
call as a general matter).
{{{
115.? [func] jinmei
src/lib/datasrc: added new zone and zone table classes for the
support of in memory data source. This is an intermediate step to
the bigger feature, and is not yet actually usable in practice.
(Trac #399, svn rTBD)
}}}
Is it now okay to commit?
--
Ticket URL: <http://bind10.isc.org/ticket/399#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list