BIND 10 #362: python coverage report via make
BIND 10 Development
do-not-reply at isc.org
Thu Nov 25 18:13:26 UTC 2010
#362: python coverage report via make
-------------------------------+--------------------------------------------
Reporter: jreed | Owner: jreed
Type: defect | Status: reviewing
Priority: major | Milestone:
Component: Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
-------------------------------+--------------------------------------------
Changes (by jelte):
* owner: jelte => jreed
Comment:
Awesome, love it.
Few comments:
the merge with sync ended up in a file that is now missing in this
branch (src/bin/xfrin/xfrin.spec)
there does not appear to be a way to only run the python coverage tests;
added to that, after
./configure --with-pycoverage
make coverage fails since lcov wasn't specified, and vice versa.
Not sure if we want to have separate targets, but if not, we should
either have something like ./configure --enable-coverage that configures
both, or
only let make coverage run the specific subset specified at
configure-time.
very small nit for the tester without patience, perhaps mention the
output directories also in the first make target (coverage), since the
rest are for most use-cases not that interesting (or possibly say this
even before mentioning targets).
The output directories for c++ and python coverage could be a little
more consistent (no real preference, but 'coverage' seems to
generic, esp. compared to py-coverage-html, i'd prefer something like
'coverage-cpp' and 'coverage-py' but again, no real preference)
--
Ticket URL: <https://bind10.isc.org/ticket/362#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list