BIND 10 #401: Timouts in the recursor

[BIND 10 Development]

#401: Timouts in the recursor
------------------------------+---------------------------------------------
      Reporter:  vorner       |        Owner:  vorner   
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  recurser     |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by stephen):

  * owner:  stephen => vorner


Comment:

 >> * The classes !QuestionInserter and !SectionInserter seem to related
 more to code associated
 >> with general DNS message manipulation than with the recursor. Should
 they be in
 >> recursor.cc or in the main DNS library?
 > They do not seem as some utility commonly used. They just hack around
 C++ inability to have
 > lambda functions and for_each strange interface. If I wrote the code,
 I'd use a
 > BOOST_FOREACH or put the classes directly inside the function that uses
 them. If I saw
 > them in the public interface of the library, I'd be asking why these
 classes are there,
 > when I can just insert into the data directly.

 Fair enough.  But a comment to that effect would be useful.

 Also, SectionInserter::sign_ appears not to be used.

 >> * Similarly, !MessageAnswer does a general transformation of a message.
 Although it takes a
 >> Recursor* argument to its constructor, it seems that this is never
 used. I would suggest
 >> that the functionality of !MessageAnswer is placed in the main DNS
 library and that the
 >> !MessageAnswer code just calls it.
 > :
 > This one inherits from DNSAnswer, which is from asiolink. I guess the
 dns library should
 > be able to work without asiolink, therefore it shouldn't contain such
 class.

 It wasn't so much that, it's just that the processing - copying a lot of
 the input query into the output response - would also seem to more about
 processing a DNS message in general rather than be recursor-specific.  As
 such, I would think it would have a lot in common with the processing in
 the authoritative server and so could be shared code.  But leave it for
 now.

 > Not that I wouldn't agree that there's need of documentation (it took me
 a while to read
 > and remember how the code works and I'll forget it soon again), but I
 think it should go
 > either  into #327 or into a separate task. Is it OK if I just create a
 ticket or put this
 > into the rteam backlog?

 I've added it as a task to the R-Team backlog.

-- 
Ticket URL: <http://bind10.isc.org/ticket/401#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development