BIND 10 #417: review: build error with clang++ for TSIG RDATA

BIND 10 Development do-not-reply at isc.org
Tue Nov 30 09:30:52 UTC 2010


#417: review: build error with clang++ for TSIG RDATA
----------------------------+-----------------------------------------------
  Reporter:  jinmei         |            Owner:  jinmei               
      Type:  defect         |           Status:  new                  
  Priority:  major          |        Milestone:  y2 12 month milestone
 Component:  DNSPacket API  |         Keywords:                       
 Sensitive:  0              |   Estimatedhours:  0                    
     Hours:  0              |         Billable:  1                    
Totalhours:  0              |         Internal:  0                    
----------------------------+-----------------------------------------------
 Could someone take a quick check on the attached patch?

 clang++ doesn't like the current implementation of tsig_250.cc because it
 refers to TSIG::TSIGImpl (a private class internally defined in the TSIG
 class) outside the scope of the TSIG class.  The attached patch avoids
 this error in a straightforward way.

 I believe it's mostly trivial, but it may beyond the "too trivial" level,
 so I'm trying to get a review.  If it cannot get reviewed quickly (within
 a day or so) I'll merge it anyway.

-- 
Ticket URL: <http://bind10.isc.org/ticket/417>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list