BIND 10 #216: Xfrin: Implement the feature items in TODO file.

[BIND 10 Development]

#216: Xfrin: Implement the feature items in TODO file.
------------------------------+---------------------------------------------
      Reporter:  zhanglikun   |        Owner:  shentingting        
          Type:  enhancement  |       Status:  reviewing           
      Priority:  major        |    Milestone:  y2 6 month milestone
     Component:  xfrin        |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:  0                   
      Billable:  1            |   Totalhours:  5.0                 
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 Replying to [comment:29 shentingting]:

 > 1. "Xfrin.init" problem: I think the initialization is necessary.
 >
 Ah, okay.  Quite tricky:-)

 But another minor point of hardcoding a magic number isn't addressed yet.

 > 2. Actually I copy connect function, send and recv function from
 asyncore.py library, and make a little changes, 0 is success, a connected
 socket call connect function again, it will make a EISCONN code. Maybe
 this is make sense.
 >
 It still doesn't make sense to me.  The asyncore code uses connect_ex(),
 so a return value of 0 is valid.  Your current code uses connect(), which
 only handles exceptions, so 0 shouldn't be a valid value.

 As for EISCONN, simply because asyncore() expects that doesn't justify the
 use of it in your specific case.  asyncore() is a generic library function
 and may need to expect more general error cases.  Please forget what
 asyncore() does, and explain whether EISCONN can validly happen *in your
 usage*.

 > 3. In fact, I have already add test_config_handler function to test
 transfers_in.
 >
 Okay.

 > 4. I am adding description for _conn_sockets_to_threads and
 _zones_to_threads.
 >
 I can't see it.  Maybe that's a local change in your working directory?

 Also, you still haven't answered my previous points one by one.  What I'd
 expect is to go through my previous sets of comments:
 http://bind10.isc.org/ticket/216?replyto=29#comment:17
 http://bind10.isc.org/ticket/216?replyto=29#comment:19
 and answer each bullet one by one.

-- 
Ticket URL: <http://bind10.isc.org/ticket/216#comment:30>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development