BIND 10 #365: clang++ support

BIND 10 Development do-not-reply at isc.org
Wed Oct 13 07:26:10 UTC 2010


#365: clang++ support
-------------------------------+--------------------------------------------
      Reporter:  jinmei        |        Owner:  UnAssigned           
          Type:  enhancement   |       Status:  reviewing            
      Priority:  major         |    Milestone:  y2 12 month milestone
     Component:  build system  |   Resolution:                       
      Keywords:                |    Sensitive:  0                    
Estimatedhours:  0.0           |        Hours:  0                    
      Billable:  1             |   Totalhours:  0                    
      Internal:  0             |  
-------------------------------+--------------------------------------------

Comment(by jinmei):

 Replying to [comment:3 jreed]:
 > Is the EXPECT_FALSE the required way for us to do this for now?
 >
 At least for supporting clang++, yes.  Otherwise the test code won't
 compile.

 > Style guide entry?
 >
 It's probably not worth an explit guide, because the revised pattern is
 actually more natural, and in the case of "false" a buildbot with clang++
 will report the breakage.  (See also my previos comment, response to
 Evan's comment)

 > Or is this something to report to googletest developers?
 >
 Probably not for the same reason.

 > Also it may be useful for some of the commit messages to explain why
 change was made versus just saying for clagg+ support. But maybe the
 changes are too obvious for others (like struct to class) to explain why
 it didn't matter with g++ or sunstudio.
 >
 I see your point.  It's a more general issue of which level of details we
 should add to commit logs though.

-- 
Ticket URL: <http://bind10.isc.org/ticket/365#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list