BIND 10 #353: Move function 'check_port()' and 'check_addr()' to one library
BIND 10 Development
do-not-reply at isc.org
Sun Oct 17 16:07:20 UTC 2010
#353: Move function 'check_port()' and 'check_addr()' to one library
-------------------------------+--------------------------------------------
Reporter: zhanglikun | Owner: vorner
Type: enhancement | Status: reviewing
Priority: major | Milestone:
Component: Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
-------------------------------+--------------------------------------------
Changes (by jinmei):
* owner: jinmei => vorner
Comment:
Replying to [comment:8 vorner]:
> Replying to [comment:7 jinmei]:
> > Understanding it may be controversial, however, I always wonder why
some people tend to write in-house versions of this type of parser (e.g.,
by using a regular expression) while the standard getaddrinfo() library is
provided exactly for this purpose.
>
> Well, because people tend not to remember library functions and regular
expression is easy way to do it. I did it according to your suggestion,
just added flag to disable name resolution.
>
Looks good, and I'm impressive to see you even included
socket.AI_NUMERICHOST, which I forgot to mention and planned to note in
this response:-)
> > That's fine for me, but I'd suggest commenting on it in the test code.
>
> Done, hopefully it is readable.
>
> What about now?
Splendid. Please go merge it to trunk.
--
Ticket URL: <https://bind10.isc.org/ticket/353#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list