BIND 10 #380: Remove duplicate code from _setup_session and config_handler

BIND 10 Development do-not-reply at isc.org
Wed Oct 20 09:45:02 UTC 2010


#380: Remove duplicate code from _setup_session and config_handler
------------------------------------+---------------------------------------
      Reporter:  zzchen_pku         |        Owner:  zzchen_pku
          Type:  enhancement        |       Status:  reviewing 
      Priority:  major              |    Milestone:            
     Component:  secondary manager  |   Resolution:            
      Keywords:                     |    Sensitive:  0         
Estimatedhours:  0.0                |        Hours:  0         
      Billable:  1                  |   Totalhours:  0         
      Internal:  0                  |  
------------------------------------+---------------------------------------
Changes (by vorner):

  * owner:  vorner => zzchen_pku


Comment:

 These changes are ok and I think they can be merged.

 However, there's a small question this reminded me of (not direcly related
 to this change) ‒ from a user point of view, wouldn't it be better if
 whatever set the value said „0.6 is too much, I'm setting it to 0.5“
 instead of just silently setting it? I could imagine a user furiously
 trying to set his 0.6 and saying „Hey, why it ignores me?“. Do we want do
 to this kind of thing later on somewhere? Or, is the logic somewhere I
 didn't notice? Should I bring it to ML or is it already written somewhere?

-- 
Ticket URL: <https://bind10.isc.org/ticket/380#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list