BIND 10 #327: early work on recursion

[BIND 10 Development]

#327: early work on recursion
---------------------------+------------------------------------------------
      Reporter:  each      |        Owner:  each                 
          Type:  defect    |       Status:  reviewing            
      Priority:  major     |    Milestone:  y2 12 month milestone
     Component:  recurser  |   Resolution:                       
      Keywords:            |    Sensitive:  0                    
Estimatedhours:  0.0       |        Hours:  0                    
      Billable:  1         |   Totalhours:  0                    
      Internal:  0         |  
---------------------------+------------------------------------------------

Comment(by stephen):

 The following is a review of the changes between r3136 and r3292, and
 lists outstanding issues (pulled down from earlier reviews where needed).
 Excluded are items that have been put down as tasks in the "R-Team" sprint
 of 20 Oct - 2 Nov 2010.

 '''r3136 -> r3292'''

 '''src/lib/asiolink/tests/asiolink_unittest.cc'''
 TODO: (not covered in this review) Logic of the tests need to be checked.

 '''src/lib/asiolink/ioaddress.h'''
 OK, but shouldn't the toText() method be declared virtual (given that
 getFamily() is)?

 '''src/bin/auth/auth_srv.h''' and '''src/bin/recurse/recursor.h'''
 Methods have been documented, but processMessage() header needs arguments
 documenting.

 Even though setVerbose() and getVerbose() methods are trivial, shouldn't
 we document them individually (and their parameters) for doxygen?

 '''src/bin/auth/auth_srv.cc'''
 Messages are being written to cerr; a proper logging system is required.

 '''src/bin/auth/tests/mockups.h'''
 Thanks for extracting the !MockSession and related classes into a separate
 file.

 Class !MockSession: it would be useful to identify the methods (by means
 of comments) that have been added over and above the !AbstractSession.

 Class !MockSession: Why are the "sent_msg" and "msg_destination" elements
 public?

 '''src/bin/auth/main.cc''' and '''src/bin/recurse/main.cc'''
 The example command line in the usage message should include "[-u]" as an
 option (although it is listed as an option in the text below).

 Default port is still 5300 (and not 53).  If this is only because it is an
 early version for testing, a comment should be added to that effect.

 '''src/bin/recurse/recursor.cc'''
 Member variables are still public.

 '''src/lib/asiolink/README'''
 TODO: Diagram has been added although text has not been greatly expanded.
 Would like to get opinion from someone else as to how useful the file is.

 '''src/bin/recurse/b10-recurse.8'''
 TODO: Not checked - need to check the output.

-- 
Ticket URL: <https://bind10.isc.org/ticket/327#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development