BIND 10 #383: Generalize IOService constructor

BIND 10 Development do-not-reply at isc.org
Fri Oct 22 14:30:43 UTC 2010


#383: Generalize IOService constructor
------------------------------+---------------------------------------------
      Reporter:  jelte        |        Owner:  each     
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  recurser     |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by each):

 Replying to [comment:4 jelte]:
 > IOService isn't used directly in those tests, so there wasn't much to
 change...

 Huh, you're right... my brain was stuck in an earlier version of the code,
 when it was necessary to pass the IOService to processMessage().  I forgot
 I'd removed that parameter.

 That being the case, both the IOService and the DNSService members can be
 deleted from recursor_unittest.cc.

 > Review comments addressed in r3312

 They look fine to me.

-- 
Ticket URL: <https://bind10.isc.org/ticket/383#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list