BIND 10 #374: Writable datasources: Basic support for writables in C++ datasrc library

[BIND 10 Development]

#374: Writable datasources: Basic support for writables in C++ datasrc library
------------------------------+---------------------------------------------
      Reporter:  jelte        |        Owner:  UnAssigned
          Type:  enhancement  |       Status:  reviewing 
      Priority:  major        |    Milestone:            
     Component:  data source  |   Resolution:            
      Keywords:               |    Sensitive:  0         
Estimatedhours:  0.0          |        Hours:  0         
      Billable:  1            |   Totalhours:  0         
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 One quick feedback: it didn't compile for me:

 {{{
 /opt/local/include/gtest/gtest.h: In function ‘testing::AssertionResult
 testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const
 T2&) [with T1 = isc::datasrc::AbstractDataSrc::Result, T2 =
 isc::datasrc::AbstractDataSrc::WriteResult]’:
 /opt/local/include/gtest/gtest.h:1300:   instantiated from ‘static
 testing::AssertionResult
 testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*,
 const char*, const T1&, const T2&) [with T1 =
 isc::datasrc::AbstractDataSrc::Result, T2 =
 isc::datasrc::AbstractDataSrc::WriteResult, bool lhs_is_null_literal =
 false]’
 sqlite3_unittest.cc:1647:   instantiated from here
 /opt/local/include/gtest/gtest.h:1263: warning: comparison between ‘const
 enum isc::datasrc::AbstractDataSrc::Result’ and ‘const enum
 isc::datasrc::AbstractDataSrc::WriteResult’
 }}}

 There were many similar warnings (treated as an error due to -Werror).

 If I made a trivial change of replacing DataSrc::SUCCESS with
 DataSrc::W_SUCCESS to the offending code:

 {{{
     EXPECT_EQ(DataSrc::SUCCESS,
               data_source.doIXFR(transaction2,
 isc::datasrc::callbackHelperRRsetIterator,
                                  &begin,
                                  &end)
     );
 }}}

 it passed, but I don't know if that was the original intention.

-- 
Ticket URL: <http://bind10.isc.org/ticket/374#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development