BIND 10 #216: Xfrin: Implement the feature items in TODO file.

BIND 10 Development do-not-reply at isc.org
Thu Oct 28 04:05:10 UTC 2010


#216: Xfrin: Implement the feature items in TODO file.
------------------------------+---------------------------------------------
      Reporter:  zhanglikun   |        Owner:  jinmei              
          Type:  enhancement  |       Status:  reviewing           
      Priority:  major        |    Milestone:  y2 6 month milestone
     Component:  xfrin        |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:  0                   
      Billable:  1            |   Totalhours:  5.0                 
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by shentingting):

  * owner:  shentingting => jinmei


Comment:

 Replying to [comment:40 jinmei]:
 > Replying to [comment:39 jinmei]:
 > > One quick not: if we cancel asynchronous connect(), EWOULDBLOCK and
 EINPROGRESS won't normally happen.
 >
 > (I meant quick "check":-)
 >
 yes, I delete the code. Now the connect function is not necessary, so I
 remove it.
 > The same comment applies to XfrinConnection.send()/recv()/close(): we
 should catch possible exceptions only.  I suggest considering in which
 case each exception can happen.  If you cannot give an explanation, we
 should probably remove it (of course, we should be careful not to ignore
 possible exceptions).
 >
 > I also noticed these methods are not tested yet.  As we discussed before
 earlier in this ticket.  Please add tests for these methods.
 >
 For send()/recv()/close(), I remove some exceptions that It can not
 happen. For the rest exception, I do not know how to test them. In
 xfrin_test, I mode these function to test other function. so Do you have
 any suggestion for this tests?
 > Other than these it looks okay.

-- 
Ticket URL: <http://bind10.isc.org/ticket/216#comment:41>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list