BIND 10 #356: Resolver address database

[BIND 10 Development]

#356: Resolver address database
-------------------------------+--------------------------------------------
      Reporter:  stephen       |        Owner:  stephen  
          Type:  enhancement   |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0        
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by ocean):

  * owner:  ocean => stephen


Comment:

 1. hash_table_unittest.cc
     Suggest to declaration and define one const static variable named
 HASHTABLE_DEFAULT_SIZE = 1009 in !HashTable class,
     so in !HashTableTest don need to use magic number 1009 directly (ref
 UNREACHABLE in !AddressEntry class), so when
     someday if we need to change the default value, we only need to change
 in one place.

 2. hash_unittest.cc
     The comments:

 {{{
     // unique values, so it does change the size of the array.  The call
 to
 }}}
 should be
 {{{
     // unique values, so it does not change the size of the array.  The
 call to
 }}}

 3. lru_list_unittest.cc
     Maybe we should choose a better name for '''Expired''' in !LruList to
 avoid confusion with '''expiration''' of TTL.

 4. nameserver_entry_unittest.cc
     line 102:

 {{{
     BasicRRset rrns_;           ///< Non-NS RRset (MX in this case)
 }}}
 It seems that the comment is not right, the rrns_ is a NS RRset instead of
 MX

-- 
Ticket URL: <http://bind10.isc.org/ticket/356#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development