BIND 10 #308: review: simple benchmark for b10-auth query handling

[BIND 10 Development]

#308: review: simple benchmark for b10-auth query handling
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  jinmei              
          Type:  enhancement  |       Status:  reviewing           
      Priority:  minor        |    Milestone:  y2 6 month milestone
     Component:  b10-auth     |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:  1.5                 
      Billable:  1            |   Totalhours:  3.0                 
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by vorner):

  * hours:  0.0 => 1.5
  * owner:  vorner => jinmei
  * totalhours:  3.0 => 4.5


Comment:

 I have few questions there (but they might be due to that I'm new to the
 code):

 * query_bench.cc:60: Is the AuthServerPtr( ) needed? Doesn't naked pointer
 (* AuthServer) convert to it automatically? Or is it to make the code more
 explicit about it?
 * query_bench.cc:79: The query variable is used only inside the for cycle.
 Is there a reason for it to be defined outside it?
 * auth_srv.h, the documentation for getCacheSlots and setCacheSlots says
 it throws no exceptions. Should the code say the same by void
 setCacheStlots(const size_t slots) throw();? Or it is not there due to
 speed reasons? And, btw, why is it const size_t, when size_t is kind of
 integer?
 * What these two do when cache is not in use? Is it an error or nop?
 * Benchmarks do not have tests, right? Because they are kind of test
 themself?
 * Is it run anywhere? I did not find any data for it or that kind of
 stuff, nor any code that calls it ‒ so it is for manual running?

 By the way, tested to merge trunk into it (only locally), and seems there
 are no conflicts and everything works, so this is clean.

-- 
Ticket URL: <http://bind10.isc.org/ticket/308#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development