BIND 10 #334: message rendering problem in xfrout

[BIND 10 Development]

#334: message rendering problem in xfrout
-------------------------+--------------------------------------------------
      Reporter:  jelte   |        Owner:  jelte    
          Type:  defect  |       Status:  reviewing
      Priority:  major   |    Milestone:           
     Component:  xfrout  |   Resolution:           
      Keywords:          |    Sensitive:  0        
Estimatedhours:  0.0     |        Hours:  0        
      Billable:  1       |   Totalhours:  0        
      Internal:  0       |  
-------------------------+--------------------------------------------------
Changes (by stephen):

  * owner:  stephen => jelte


Comment:

 Changes are OK - go ahead an merge.

 Suggest that another ticket be opened to extend the tests.
 test_send_message_with_last_soa is only tested with a message_upper_len
 value of 0; another test needs to be added with a value of this parameter
 large enough to check that attempting to add the final SOA to a full
 message will trigger the sending of two messages.

 Suggestion for optimization: get_rrset_length obtains the wire format of
 the RRset in order to determine its length.  The wire format is then
 discarded, but is presumably recreated when the RRset is actually added to
 the message.  Could we save a second parse of the RRset by retaining the
 wire format of the message and adding a method to the message class to
 accept an RRset in that format?

-- 
Ticket URL: <https://bind10.isc.org/ticket/334#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development