BIND 10 #191: Implement a initial version of stats

BIND 10 Development do-not-reply at isc.org
Thu Sep 16 14:14:54 UTC 2010


#191: Implement a initial version of stats
-----------------------------+----------------------------------------------
      Reporter:  naokikambe  |        Owner:  naokikambe          
          Type:  task        |       Status:  reviewing           
      Priority:  major       |    Milestone:  y2 6 month milestone
     Component:  statistics  |   Resolution:                      
      Keywords:              |    Sensitive:  0                   
Estimatedhours:  20.0        |        Hours:  0                   
      Billable:  0           |   Totalhours:  3.83                
      Internal:  0           |  
-----------------------------+----------------------------------------------
Changes (by jelte):

  * owner:  jinmei => naokikambe


Comment:

 Some other comments:

 stats.py.in:

 line 172: I think the assignment of self.subject is already done by the
 call to the superclasses __init__

 line 205: eek, eval(). Even though we only eval something out of files we
 provide, it is still scary, and looks unnecessary in this case;
 {{{callback = getattr(self, name)}}}
 should also work


 More general comments:
 I noticed in the spec file that the statistics data is considered
 configuration (it is under "config_data"). I personally think this is
 confusing and possible also error-prone. I propose we extend the .spec
 format with a "stats_data", on the same level as "config_data". Right now,
 it could have the same semantics, but for starters it keeps statistics
 data like 'boot time' away from configuration.

 What exactly are those Stub classes supposed to do? Are they only for
 testing or is the intent that modules use them?

-- 
Ticket URL: <https://bind10.isc.org/ticket/191#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list