BIND 10 #308: review: simple benchmark for b10-auth query handling

BIND 10 Development do-not-reply at isc.org
Fri Sep 17 06:21:15 UTC 2010


#308: review: simple benchmark for b10-auth query handling
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  vorner              
          Type:  enhancement  |       Status:  reviewing           
      Priority:  minor        |    Milestone:  y2 6 month milestone
     Component:  b10-auth     |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:  0                   
      Billable:  1            |   Totalhours:  4.95                
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 Replying to [comment:6 vorner]:

 Forgot to respond to one more point:

 > * auth_srv.h, the documentation for getCacheSlots and setCacheSlots says
 it throws no exceptions. Should the code say the same by void
 setCacheStlots(const size_t slots) throw();? Or it is not there due to
 speed reasons? And, btw, why is it const size_t, when size_t is kind of
 integer?
 >
 Regarding 'const size_t'.  It's because this parameter is "const" in the
 method, i.e., it's not expected to changed within the method.

 Ideally, we can omit this qualifier in the declaration (if that's the
 point of your question).  Unfortunately, however, SunStudio is broken in
 this sense and fails to match the method signature if this type of const
 is missing in the declaration.

 (I think we should note this in our coding guideline page.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/308#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list