BIND 10 #191: Implement a initial version of stats
BIND 10 Development
do-not-reply at isc.org
Fri Sep 17 14:31:13 UTC 2010
#191: Implement a initial version of stats
-----------------------------+----------------------------------------------
Reporter: naokikambe | Owner: jelte
Type: task | Status: reviewing
Priority: major | Milestone: y2 6 month milestone
Component: statistics | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 20.0 | Hours: 0.5
Billable: 0 | Totalhours: 4.33
Internal: 0 |
-----------------------------+----------------------------------------------
Changes (by naokikambe):
* hours: 0.0 => 0.5
* totalhours: 4.33 => 4.83
Comment:
Replying to [comment:17 jelte]:
> stats.py.in:
>
> line 172: I think the assignment of self.subject is already done by the
call to the superclasses __init__
I removed this at r2970.
> line 205: eek, eval(). Even though we only eval something out of files
we provide, it is still scary, and looks unnecessary in this case;
> {{{callback = getattr(self, name)}}}
> should also work
Yeah, I fixed this at r2973.
> More general comments:
> I noticed in the spec file that the statistics data is considered
configuration (it is under "config_data"). I personally think this is
confusing and possible also error-prone. I propose we extend the .spec
format with a "stats_data", on the same level as "config_data". Right now,
it could have the same semantics, but for starters it keeps statistics
data like 'boot time' away from configuration.
Yes, that's right. But in an initial version, I chose to use it under
"config_data". From next version, I'll try to extend spec file of stats
module for it.
> What exactly are those Stub classes supposed to do? Are they only for
testing or is the intent that modules use them?
Stub is only for testing, not really installed. It works as real
''bind10'' or ''b10-auth'' against ''b10-stats''. It is never used by
other modules.
--
Ticket URL: <https://bind10.isc.org/ticket/191#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list