BIND 10 #348: remove unnecessary cast from pydnspp binding
BIND 10 Development
do-not-reply at isc.org
Wed Sep 22 04:33:06 UTC 2010
#348: remove unnecessary cast from pydnspp binding
---------------------------+------------------------------------------------
Reporter: jinmei | Owner: jreed
Type: defect | Status: new
Priority: critical | Milestone: y2 12 month milestone
Component: build system | Keywords:
Sensitive: 0 | Estimatedhours: 0
Hours: 0 | Billable: 1
Totalhours: 0 | Internal: 0
---------------------------+------------------------------------------------
Please someone quickly review the attached patch.
I believe it solves the build error for NetBSD:
http://bind10.isc.org/~tester/builder/BIND10/20100922005000-NetBSD5-amd64/logs/build.out
The offending parameters of PyArg_ParseTuple() is the variable argument
part, so we should be able to omit the cast in the first place (in fact, I
omitted cast for the python binding of the EDNS class in trac #311). In
that sense this change should be harmless.
IMO the NetBSD's behavior on this point is deviant (again), but since we
can save them for a trivial, harmless change, we should do it.
I don't think we need a changelog entry for this.
--
Ticket URL: <http://bind10.isc.org/ticket/348>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list