BIND 10 #349: Busyloop in all python processes caused by nonblock reads of bus

[BIND 10 Development]

#349: Busyloop in all python processes caused by nonblock reads of bus
-------------------------------+--------------------------------------------
      Reporter:  vorner        |        Owner:  vorner   
          Type:  defect        |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0.25     
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jinmei):

  * hours:  0.0 => 0.25
  * owner:  UnAssigned => vorner
  * totalhours:  0.0 => 0.25


Comment:

 Replying to [comment:2 vorner]:
 > Hopefully fixed, in the branches/trac349. Revisions are r3003-r3005.

 The fix looks okay (and worked for my machine).

 Some minor comments:
  - please provide suggested changelog entry
  - please describe the new argument 'nonblock'
  - according to http://www.python.org/dev/peps/pep-0008/, spaces around =
 for the default parameter should be omitted:
 {{{
     def check_command(self, nonblock=True):
 }}}
   (I know our code isn't consistent on this point.  but this is the
 guideline we agreed to follow)
  - I think we should write a test for the case of non default 'nonblock'
 parameter (i.e. False).

-- 
Ticket URL: <https://bind10.isc.org/ticket/349#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development