BIND 10 #299: AXFR fails half the time

[BIND 10 Development]

#299: AXFR fails half the time
-----------------------------+----------------------------------------------
      Reporter:  zzchen_pku  |        Owner:  jinmei   
          Type:  defect      |       Status:  reviewing
      Priority:  major       |    Milestone:           
     Component:  xfrout      |   Resolution:           
      Keywords:              |    Sensitive:  0        
Estimatedhours:  0.0         |        Hours:  0        
      Billable:  1           |   Totalhours:  1.0      
      Internal:  0           |  
-----------------------------+----------------------------------------------
Changes (by zzchen_pku):

  * owner:  zzchen_pku => jinmei


Comment:

 Replying to [comment:19 jinmei]:
 > I suspect with this approach the xfrout thread cannot catch shutdown.
 Do you mean xfrout server can't catch the event of xfrout client shutdown.
 Since Xfrout socket is in blocking mode, when a recv() returns 0 bytes, it
 means the xfrout client has closed the connection, at this time we can
 break the handle loop and close this request.
 > On a related note, polling every 0.5 sec is ugly.  We should revisit
 this design.
 Yeah, polling reduces Xfrout server's responsiveness to a shutdown request
 and wastes cpu at all other times, I'll create a new ticket for it.
 > Another minor point.  Please don't leave commented-out code without any
 explnation:
 > {{{
 >      #self._log.log_message("error", "Failed to receive the file
 descriptor for XFR connection")
 > }}}
 Sorry, I forgot to add comment for it. Because the log will display each
 time xfrout client shutdown. I have updated the recv_fd() function, which
 will return different value to distinguish shutdown event from error
 handling, or any other good suggestion?

-- 
Ticket URL: <https://bind10.isc.org/ticket/299#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development