BIND 10 #267: python log shouldn't die with OSError
BIND 10 Development
do-not-reply at isc.org
Thu Sep 30 11:51:57 UTC 2010
#267: python log shouldn't die with OSError
--------------------------+-------------------------------------------------
Reporter: jinmei | Owner: zzchen_pku
Type: defect | Status: reviewing
Priority: major | Milestone: 06. 4th Incremental Release
Component: logging | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours:
Billable: 1 | Totalhours:
Internal: 0 |
--------------------------+-------------------------------------------------
Changes (by stephen):
* owner: stephen => zzchen_pku
Comment:
>> ''Class !TestSysLogHandler''
>> test_emit(): This only checks that the emit() call does not fail - it
does not check that
>> the record has been sent to the syslog stream.
> The destination of syslog stream depends on OS type and syslog.conf, so
it is difficult to
> trace and check the log message. Do you have any good suggestions?
Not really. At the time of writing I had thought about generating a unique
message in the test - possibly including the date/time the message was
created so as to distinguish it from other runs of the test - then
searching the syslog file for that string. However, the problem here is
that the name of the syslog file is not standardised, e.g. by default it
is "syslog" on Ubuntu and "system.log" on OS X. How we check that the
modules in BIND-10 are logging correctly is a more generalised problem and
something we should discuss further. I suggest that the code be left as it
is for now.
All other changes checked and are OK.
Please go ahead and merge with trunk.
--
Ticket URL: <https://bind10.isc.org/ticket/267#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list