BIND 10 #698: ModuleCCSession object may group_unsubscribe in the closed CC session in being deleted

[BIND 10 Development]

#698: ModuleCCSession object may group_unsubscribe in the closed CC session in
being deleted
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  vorner
  naokikambe                         |               Status:  reviewing
                     Type:  defect   |            Milestone:
                 Priority:  major    |  Sprint-20110405
                Component:           |           Resolution:
  message-library                    |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  3.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => vorner


Comment:

 Hello,

 Replying to [comment:11 vorner]:
 > > However I think the unittest never fails without this change even if
 this exception is raised. Because this exception in deleting the object is
 just ignored like this. Is that correct?
 >
 > If we created a test where the object was created, closed and force-
 deleted, the exception should be raised in the case it is not properly
 checked (eg. without the fix). Something like this (not exact code) could
 do the trick, but I didn't try it:
 >
 > {{{
 > # Get the session somewhere
 > session.close()
 > session = None
 > gt.collect() # Force garbage collection, which forces deletion of the
 object
 > }}}
 >
 > Would that be possible?
 No. I could not make it failed. (Result did not change.) However I could
 make it failed by adding another test case like following.
 {{{
     def test_del(self):
         fake_session = FakeModuleCCSession()
         mccs = self.create_session("spec1.spec", None, None, fake_session)
         mccs.close()
         mccs.__del__()
 }}}
 Is that OK ?

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/698#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development